Return NaN from history if any of the calculations end up as NaN #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdroege
commented
Jun 3, 2024
sdroege
force-pushed
the
avoid-nan
branch
3 times, most recently
from
878680a to
873de1c
Compare
sdroege
commented
Jun 3, 2024
sdroege
commented
Jun 3, 2024
|
@sdroege Thanks and sorry for late reply. Don't think i have any strong opinions how to fix it, in the software where this was triggered we're looking for NaN and Inf samples before using ebur128 as a workaround atm. |
Using inline assembly would require 1.75 as MSRV.
This avoids returning non-sensical results, or in case of history-based loudness range calculations a panic. All filter processing already handles NaN gracefully. Fixes #43
sdroege
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids returning non-sensical results, or in case of history-based
loudness range calculations a panic.
All filter processing already handles NaN gracefully.
Fixes #43